Skip to content

gpuResampSlc.cu: fix out of bounds reading bug in transformTile #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
scottstanie wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

gpuResampSlc.cu: fix out of bounds reading bug in transformTile #214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cxx/isce3/cuda/image/Resample.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ void _resampleToCoordsGlobal(
// done with a multiple of the thrd_per_block pixels, but the output data size will
// typically be smaller than this multiple. So, some calls to this function on
// the device will be for non-existent pixels which must be discarded.
if (pixel_index > resampled_block_width * resampled_block_length) return;
if (pixel_index >= resampled_block_width * resampled_block_length) return;

const auto chip_size = static_cast<size_t>(SINC_ONE);

Expand Down
4 changes: 2 additions & 2 deletions cxx/isce3/cuda/image/gpuResampSlc.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,15 +125,15 @@ void transformTile(thrust::complex<float> *resampledSlc,
// Check if resampling possible at the starting rows of a tile.
(iRowResamp < chipHalf)
// Check if resampling possible at the ending rows of a tile.
|| (iRowResamp + chipHalf > inReadableLength);
|| (iRowResamp + chipHalf >= inReadableLength);

// Check if resampled column index is in bounds by checking if chip
// used to resample can be populated.
const bool colOutOfBounds =
// Check if resampling possible at starting columns of a tile.
(iColResamp - chipHalf < 0)
// Check if resampling possible at the ending columns of a tile.
|| (iColResamp + chipHalf > inWidth);
|| (iColResamp + chipHalf >= (long long int)inWidth);

// Skip computations if indices out of bound or az/rng not in doppler
if (rowOutOfBounds || colOutOfBounds || iRowResamp < 0 || iColResamp < 0)
Expand Down