Fix vocab generation: use vocab CLI instead of vocab2md.py #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #46 switched from `vocab markdown` to `python vocab2md.py`, but vocab2md.py requires rdflib which isn't in requirements.txt. The workflow already installs vocab_tools via pipx, which provides the `vocab` CLI. This reverts to using that CLI. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
PR #46 switched from
vocab markdownCLI topython vocab2md.py, butvocab2md.pyrequiresrdflibwhich isn't installed in the workflow environment.This caused all vocabulary generation to fail with:
Result: vocabulary pages render with empty content.
Fix
Revert to using
vocab markdownCLI fromvocab_tools, which is already installed via pipx in the workflow:Changes
scripts/generate_vocab_docs.sh: Replacepython vocab2md.pywithvocab markdownTest Plan
🤖 Generated with Claude Code