Enable filtering of notification email template#18
Open
timothyjensen wants to merge 1 commit into
Open
Conversation
Author
|
Hi @isabelc, just wondering if you have any thoughts or suggestions about this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firstly, thanks so much for building and maintaining this plugin!
While setting this up for a client I found one limitation that prevented me from doing what I needed to do: change the email content based on the comment and subscriber info.
In this PR I added a filter with access to the comment and subscriber objects, which will let devs customize the notification message as needed.