My Ada Sidebar #1850
Open
My Ada Sidebar #1850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With `site` being true, the DOM layout is as it is for Sci pages at the moment. With `site` false, the parent Row, the sidebar Col and the MainContent Col are all removed, keeping the DOM clean when unused.
[VRT] Update baselines for feature/my-ada-sidebar
[VRT] Update baselines for feature/my-ada-sidebar
Ada defaults to card view on smaller screens, which is now the case for the tests
Because the header is now collapsed for the Ada tests, the header links can no longer be selected by role.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1850 +/- ##
==========================================
+ Coverage 42.36% 42.45% +0.09%
==========================================
Files 575 577 +2
Lines 24395 24471 +76
Branches 8044 8109 +65
==========================================
+ Hits 10334 10390 +56
- Misses 13397 13416 +19
- Partials 664 665 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
[VRT] Update baselines for feature/my-ada-sidebar
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A good chunk of these line changes are just whitespace from adjusting the structure of the sidebar-containing component!