768 booster video cta #454
Open
+54
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…booster_video_CTA
|
|
Parth097
requested changes
Jan 23, 2026
Parth097
left a comment
Parth097
left a comment
There was a problem hiding this comment.
Just need to look at the disabling of eslint issue, apart from that looks good to me :)
| followedAtLeastOneSoftLink?: boolean; | ||
| } | ||
|
|
||
| // eslint-disable-next-line no-var |
There was a problem hiding this comment.
Is there is good enough reason to disable es-lint here?
Is there another way which es-lint will accept this?
Author
There was a problem hiding this comment.
well, it doesn't like it and is not an issue
There was a problem hiding this comment.
So we enforce es-lint so that we meet some standards within the codebase.
I know it is really annoying but we need to make sure we dont disable eslint otherwise there is no point having it in the first place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.