Open
Conversation
rwiltz
reviewed
Sep 3, 2025
| carb.log_info("Vive tracker initialized (mock)") | ||
|
|
||
| def update(self): | ||
| if not PYSURVIVE_AVAILABLE: |
There was a problem hiding this comment.
If libsurvive is not avaliable, I'd prefer to throw a runtime error vs silent failing like this.
rwiltz
reviewed
Sep 3, 2025
| if libsurvive_python_path: | ||
| if libsurvive_python_path not in sys.path: | ||
| sys.path.insert(0, libsurvive_python_path) | ||
| carb.log_info(f"Using LIBSURVIVE_PYTHON_PATH={libsurvive_python_path}") |
There was a problem hiding this comment.
Can we pull libsurvive and build it locally? That way we don't have to depend on user installing it.
rwiltz
reviewed
Sep 4, 2025
rwiltz
reviewed
Sep 4, 2025
rwiltz
reviewed
Sep 4, 2025
There was a problem hiding this comment.
Can we rename this to something that is specific to manus-vive? Or do you disagree?
cathyliyuanchen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.