bcn 04/19 Chloé#5
Open
chloeleteinturier wants to merge 1 commit into
Open
Conversation
tawebbcn
reviewed
Apr 2, 2019
Collaborator
tawebbcn
left a comment
tawebbcn
left a comment
There was a problem hiding this comment.
Overall really good job! Simple and good structure, keep it like that, good use of classes instead of id.
| @@ -0,0 +1,50 @@ | |||
| *{ | |||
Collaborator
There was a problem hiding this comment.
Remember to add the reset part to make your live easier.
| <section class="description"> | ||
| <p>This was my grandmother's apple pie recipe. I have never seen another one quite like it. It will always be my favorite and has won me several first place prizes in local competitions. I hope it becomes one of your favorites as well!</p> | ||
| <img class="info" src="images/recipe-info.png" alt="recipe-info"> | ||
| <hr> |
Collaborator
There was a problem hiding this comment.
Try no to use hr for styling, only when it makes sense to have a line break from structure for example poetry :). The concept is separation of concerns, css should be responsable to create that space and not html (in charge of strcuture)
| <li>- 8 Granny Smith apples - peeled, cored and sliced</li> | ||
| </ul> | ||
| <img class="info" src="images/cooking-info.png" alt="cooking-info"> | ||
| <hr> |
| <li>- 1/4 cup grated Parmesan cheese</li> | ||
| </ul> | ||
| <img class="info" src="images/cooking-info.png" alt="cooking-info"> | ||
| <hr> |
|
|
||
| </main> | ||
|
|
||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.