BCN 0419 - Jason#16
Conversation
tawebbcn
left a comment
tawebbcn
left a comment
There was a problem hiding this comment.
Try to review the comments and fix it. If you have any question please let us know!
| } | ||
| .images-center2 { | ||
|
|
||
| padding: 10px 180px 10px 180px; |
There was a problem hiding this comment.
Remember that you can use the shorthand: padding: 10px 180px;
| <body> | ||
| <header> | ||
| <h1>Apple Pies</h1> | ||
| </header> |
There was a problem hiding this comment.
I would have a general structure for the html like:
<header></header>
<main></main>
<footer></footer>
As general layout. Maybe this exercise had no footer but definitely a main tag
|
|
||
| <div class="container"> | ||
| <section> | ||
| <div> |
There was a problem hiding this comment.
Not sure you need this div :)
| <hr> | ||
| <section> | ||
| <div class="ingredients"> | ||
| <p> |
There was a problem hiding this comment.
This p doesn't make sense here. A ptag is for paragraphs.
| <img src="/Users/jasoncuellar/code/labs/lab-css-recipes-clone/apple-pie-starter-code/images/recipe-info.png" alt="recipe info " class="images-center1"> | ||
| </div> | ||
| </section> | ||
| <hr> |
There was a problem hiding this comment.
Try not to us hr for styling. If you need a space do it with CSS better. Best practice is separation of concerns. HTML only structure and content, CSS only styling.
|
|
||
| <div class="container"> | ||
| <section> | ||
| <div> |
There was a problem hiding this comment.
Be careful with indentation. Something happened here, is different from the previous exercise
| <div class="directions"> | ||
| <h2>Directions</h2> | ||
| <ol> | ||
| <li> |
There was a problem hiding this comment.
Fix indentation! li should be inside ```ul````
2 participants
No description provided.