BCN-0419-Allyn Alda#13
Open
allynkalda wants to merge 2 commits into
Open
Conversation
added 2 commits
April 1, 2019 20:00
tawebbcn
reviewed
Apr 2, 2019
Collaborator
tawebbcn
left a comment
tawebbcn
left a comment
There was a problem hiding this comment.
Good job! Revise a few thing, fix indentation! :)
| @@ -0,0 +1,53 @@ | |||
| @import "http://fonts.googleapis.com/css?family=Open+Sans"; | |||
|
|
|||
| h1, body, html, main { | |||
Collaborator
There was a problem hiding this comment.
Maybe you could add more rules for the reset that will make the styling easier.
| <title>Apple Pie Recipe</title> | ||
| <link rel = "stylesheet" type = "text/css" href = "./css/main.css" /> | ||
| </head> | ||
| <body> |
Collaborator
There was a problem hiding this comment.
You are missing a basic structure of the site using the header and main tags:
<header></header>
<main></main>
And inside will go everything else. Usually you will have a footer as well.
| <img class="images" src="images/recipe-info.png" alt=recipe-apple-pie> | ||
| </section> | ||
| </div> | ||
| <hr> |
Collaborator
There was a problem hiding this comment.
Don't use hrtags for styling. Concept of separation of responsibilities. CSS is in charge of creating space if you need to. I would only use hr for example in poetry.
| <img class="images" src="images/cooking-info.png" alt=cooking-apple-pie> | ||
| </section> | ||
| </div> | ||
| <hr> |
| degrees C). Continue baking for 35 to 45 minutes, until apples are soft.</li> | ||
| </ol> | ||
| </section> | ||
| </div> |
| <img class="images" src="images/recipe-info.png" alt=recipe-apple-pie> | ||
| </section> | ||
| </div> | ||
| <hr> |
Collaborator
There was a problem hiding this comment.
Same comments as the first exercise.
| <li>2 slices Swiss cheese, diced</li> | ||
| <li>1/4 cup grated Parmesan cheese</li> | ||
| </ul> | ||
| <img class="images" src="images/cooking-info.png" alt=cooking-french-onion> |
| <li>1/2 cup packed brown sugar</li> | ||
| <li>8 Granny Smith apples - peeled, cored and sliced</li> | ||
| </ul> | ||
| <img class="images" src="images/cooking-info.png" alt=cooking-apple-pie> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.