Integrate ConditionsAPI to volume resource#1424
Closed
Rohit-0505 wants to merge 1 commit intoironcore-dev:mainfrom
Closed
Integrate ConditionsAPI to volume resource#1424Rohit-0505 wants to merge 1 commit intoironcore-dev:mainfrom
ConditionsAPI to volume resource#1424Rohit-0505 wants to merge 1 commit intoironcore-dev:mainfrom
Conversation
opensovereigncloud-user
force-pushed
the
osc/enh/integrate-conditionsAPI-to-volume
branch
3 times, most recently
from
cab395e to
5312198
Compare
opensovereigncloud-user
force-pushed
the
osc/enh/integrate-conditionsAPI-to-volume
branch
from
5312198 to
cefaf88
Compare
Member
|
Here is a good read on conditions in the Kubernetes resources and how they should be used. |
Contributor
Author
|
Closing this PR, adding conditions API for volume resource is not needed at the moment, since there are no dependent resources that would make use of these conditions in their controller reconciliation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
volume_typeswith ConditionsAPI to integrate withVolumeStatus/ref Integrate
conditionsAPI for all relevant API resources in IronCore #1343