Open
Conversation
Contributor
Author
|
Improved tests required: should capture statistics that are different across pages and row_groups and include null_values and unique_value counts |
Contributor
Author
|
Not ready to merge. |
* bitpacking should work for any length of data, not just multiple of 8 (last packed is padded if less than 8) * Improve runs estimation - only start a new run if we are at a mod 8 === 0, otherwise use bitpacking
This moves data into encoded buffer as soon as possible, reducing memory requirements for the whole rowGroup
ZJONSSON
force-pushed
the
statistics
branch
2 times, most recently
from
e6a3cfa to
70a67f1
Compare
Default for all columns unless `statistics: false` in the field definition
|
Hi, I see this PR has been pending for almost a year now. Do you need any help? |
Contributor
|
Is there anything I could do to help with this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subsequent to #52
Calculate statistics for each page and each column, including:
max_value, min_value, null_count, distinct_count. For any columns that are sorted, the statistics either on column level or page level allows skipping over sections that are not of interest.