Switch from call_id to task_id for consistency#553
Switch from call_id to task_id for consistency#553denismakogon wants to merge 16 commits intoiron-io:masterfrom
Conversation
|
Is this only for async functions? We named them call_id in reference to a "functions calls", not sure we should have task_id and call_id. |
|
@treeder the thing is that Async execution returns call_id, but I need to query |
|
@seiflotfy @pedronasser @treeder Guys, can we make certain decision on this one? |
|
So I am pretty ok with that change, we are not 1.0 and I like the changes to the docs. |
|
A good merge message covering on the reason and consequences of this change is a must. Regarding everything else, LGTM. |
|
The main thing that bugs me about this is having different names for essentially the same thing. We should choose one or the other across the board. |
|
@treeder isn't |
ucirello
left a comment
There was a problem hiding this comment.
I am just trying to decouple my account from this.
As part of async execution HTTP API response IronFunctions returns
call_id. But it's actually referring to task ID (frommodels.Task). In order to keep consistency between tasks objects (that are available via/tasksHTTP API) that are containingtask_idand nocall_idit is necessary to renamecall_idtotask_id.This patch renames
call_idthat comes as part of API response on async execution request totask_idfor API consistency purposes.HTTP API impact:
call_idrenamed totask_idPartially addresses: #415