[#203] Handling for special characters in requests#219
Merged
Conversation
Contributor
Author
|
Squashed |
Some clients request URL-encoded object Keys, so these test putting and listing objects with reserved characters which would be URL-encoded if needed. The default encoding type is UTF-8.
Whenever a request is parsed, it encodes special characters so that different parts of the URL can be parsed. While this is helpful and good, these special characters need to be decoded in the target's path so that the object or prefix in question can be referenced properly.
Contributor
Author
|
#'d, mergin |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #203
Seems to be working for the most part, with caveats for some multipart weirdness. We have discussed this and decided there are issues which need addressing there which fall outside the scope of these changes.