Skip to content

[#203] Handling for special characters in requests#219

Merged
alanking merged 3 commits into
irods:mainfrom
alanking:203.m
Mar 5, 2026
Merged

[#203] Handling for special characters in requests#219
alanking merged 3 commits into
irods:mainfrom
alanking:203.m

Conversation

@alanking
Copy link
Copy Markdown
Contributor

@alanking alanking commented Mar 5, 2026

Addresses #203

Seems to be working for the most part, with caveats for some multipart weirdness. We have discussed this and decided there are issues which need addressing there which fall outside the scope of these changes.

Copy link
Copy Markdown
Collaborator

@korydraughn korydraughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.

Comment thread endpoints/s3/src/listobjects.cpp Outdated
Copy link
Copy Markdown
Collaborator

@korydraughn korydraughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squash it.

@alanking
Copy link
Copy Markdown
Contributor Author

alanking commented Mar 5, 2026

Squashed

alanking added 3 commits March 5, 2026 12:29
Some clients request URL-encoded object Keys, so these test putting and
listing objects with reserved characters which would be URL-encoded if
needed. The default encoding type is UTF-8.
Whenever a request is parsed, it encodes special characters so that
different parts of the URL can be parsed. While this is helpful and
good, these special characters need to be decoded in the target's path
so that the object or prefix in question can be referenced properly.
Copy link
Copy Markdown
Collaborator

@korydraughn korydraughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pound it.

@alanking
Copy link
Copy Markdown
Contributor Author

alanking commented Mar 5, 2026

#'d, mergin

@alanking alanking merged commit b3bacc7 into irods:main Mar 5, 2026
@alanking alanking deleted the 203.m branch March 5, 2026 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants