Skip to content

[#215] Ignore build warnings in Boost include#216

Merged
alanking merged 1 commit into
irods:mainfrom
alanking:215.m
Mar 3, 2026
Merged

[#215] Ignore build warnings in Boost include#216
alanking merged 1 commit into
irods:mainfrom
alanking:215.m

Conversation

@alanking
Copy link
Copy Markdown
Contributor

@alanking alanking commented Mar 3, 2026

Addresses #215

korydraughn
korydraughn previously approved these changes Mar 3, 2026
Copy link
Copy Markdown
Collaborator

@korydraughn korydraughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Pound it.

@SwooshyCueb
Copy link
Copy Markdown
Member

please use #pragma gcc instead of #pragma clang. this is compatible with both compilers

@alanking
Copy link
Copy Markdown
Contributor Author

alanking commented Mar 3, 2026

I was wondering about that. Will update

@alanking
Copy link
Copy Markdown
Contributor Author

alanking commented Mar 3, 2026

#pragma clang replaced with #pragma gcc for lines affected by this PR as well as a couple of others I found elsewhere in the codebase (separated for visibility). There's one in the third-party directory which I did not touch:

$ grep -nrI "pragma clang diagnostic ignored"
third-party/date/include/date/tz.h:64:# pragma clang diagnostic ignored "-Wconstant-logical-operand

@alanking
Copy link
Copy Markdown
Contributor Author

alanking commented Mar 3, 2026

Whoops, should be #pragma GCC, not #pragma gcc: https://gcc.gnu.org/onlinedocs/gcc/Diagnostic-Pragmas.html

Fixed.

@korydraughn korydraughn dismissed their stale review March 3, 2026 20:43

Code has changed since last review.

Copy link
Copy Markdown
Collaborator

@korydraughn korydraughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine.

Please re-run that one failed GHA to get the green dot and we'll get this in.

@alanking
Copy link
Copy Markdown
Contributor Author

alanking commented Mar 3, 2026

Green now

@korydraughn
Copy link
Copy Markdown
Collaborator

Squash to taste.

@alanking
Copy link
Copy Markdown
Contributor Author

alanking commented Mar 3, 2026

Squashed

And re-enable build warnings in the build script for the builder Dockerfile.
Copy link
Copy Markdown
Collaborator

@korydraughn korydraughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pound it.

@alanking
Copy link
Copy Markdown
Contributor Author

alanking commented Mar 3, 2026

#'d, mergin

@alanking alanking merged commit ceef58d into irods:main Mar 3, 2026
5 checks passed
@alanking alanking deleted the 215.m branch March 3, 2026 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants