[#215] Ignore build warnings in Boost include#216
Merged
Conversation
korydraughn
previously approved these changes
Mar 3, 2026
Collaborator
korydraughn
left a comment
There was a problem hiding this comment.
Looks good to me.
Pound it.
Member
|
please use |
Contributor
Author
|
I was wondering about that. Will update |
Contributor
Author
|
|
Contributor
Author
|
Whoops, should be Fixed. |
korydraughn
reviewed
Mar 3, 2026
Collaborator
korydraughn
left a comment
There was a problem hiding this comment.
Changes look fine.
Please re-run that one failed GHA to get the green dot and we'll get this in.
Contributor
Author
|
Green now |
Collaborator
|
Squash to taste. |
Contributor
Author
|
Squashed |
And re-enable build warnings in the build script for the builder Dockerfile.
Contributor
Author
|
#'d, mergin |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #215