add config-driven scripts for htcondor#44
Open
gsharma99 wants to merge 13 commits intoiris-hep:hpc_workflow_managementfrom
Open
add config-driven scripts for htcondor#44gsharma99 wants to merge 13 commits intoiris-hep:hpc_workflow_managementfrom
gsharma99 wants to merge 13 commits intoiris-hep:hpc_workflow_managementfrom
Conversation
…definitions to config.pipeline.yaml, issue iris-hep#12
gsharma99
force-pushed
the
feature/config-driven-pipeline
branch
from
fb4656f to
d2168f6
Compare
…efinitions to config.pipeline.yaml, issue iris-hep#12
…pipeline.yaml, issue iris-hep#12
…nd the config.pipeline.yaml, issue iris-hep#12
…s/nerual_likelihood_ratio_estimation, issue iris-hep#12
…the config.pipeline.yaml, issue iris-hep#12
gsharma99
force-pushed
the
feature/config-driven-pipeline
branch
from
c2333e6 to
aab2c1b
Compare
gsharma99
force-pushed
the
feature/config-driven-pipeline
branch
from
b4bdfab to
d58dae1
Compare
JaySandesara
requested changes
Feb 6, 2026
Collaborator
JaySandesara
left a comment
JaySandesara
left a comment
There was a problem hiding this comment.
Preliminary changes suggested to fix bugs in .dag file
JaySandesara
requested changes
Feb 6, 2026
JaySandesara
requested changes
Feb 6, 2026
JaySandesara
requested changes
Feb 7, 2026
JaySandesara
reviewed
Feb 7, 2026
Comment on lines
-152
to
+147
| # Override load_trained_models if --train argument is present | ||
| if force_train: | ||
| logger.info("Force training mode enabled via CLI.") | ||
| logger.info(f"Force training enabled. Setting load_trained_models=False for {process_type}.") | ||
| settings['load_trained_models'] = False | ||
| else: | ||
| logger.info(f"Using USE_SAVED_MODELS={settings['load_trained_models']} from config.") | ||
| logger.info(f"Using load_trained_models={settings['load_trained_models']} from config for {process_type}.") |
Collaborator
There was a problem hiding this comment.
I dont understand here how the load_trained_models setting is being used except to print a log message. @gsharma99
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue #12
cc @JaySandesara