Merged
Conversation
Kernel execution is asyn, it can outlive the test function if we don't check the result or explicitly sychronize. Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
Hardcode84
force-pushed
the
fix-cache-race
branch
from
50a3f0a to
3339e5c
Compare
Contributor
Author
|
skipped the test for now, even when it's not crashing it produces incorrect result. |
Contributor
Author
|
After some internal discussion, our waveasm caching story is completely broken at the moment, but let's keep this test anyway in skipped state, so eventually we can fix it. |
ftynse
approved these changes
Mar 20, 2026
| @require_e2e | ||
| @require_cache | ||
| @require_cdna3 | ||
| @skip(reason="Crashes and/or produces incorrect results.") |
Contributor
There was a problem hiding this comment.
Should this use pytest functionality instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kernel execution is async, it can outlive the test function if we don't check the result or explicitly synchronize.