remove the static pytorch-rocm-requirements.txt, always use generator#1147
Merged
willghatch merged 1 commit intomainfrom Mar 24, 2026
Merged
Conversation
willghatch
force-pushed
the
users/willghatch/remove-static-rocm-require
branch
from
a55d202 to
991f94a
Compare
The static file hardcoded ROCm 6.4, which breaks on other ROCm versions. Use gen-pytorch-rocm-requirements.py everywhere (IE in documentation, CI) instead, which auto-detects the installed ROCm version and probes for a matching PyTorch wheel source. Also adjust generator version regex to allow build number. This is a follow-up to the discussion in #1134 Signed-off-by: William G Hatch <william@hatch.uno>
willghatch
force-pushed
the
users/willghatch/remove-static-rocm-require
branch
from
991f94a to
7d04f83
Compare
Contributor
Author
ftynse
approved these changes
Mar 24, 2026
Contributor
ftynse
left a comment
ftynse
left a comment
There was a problem hiding this comment.
🤷 maybe torch version changed in the meantime
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The static file hardcoded ROCm 6.4, which breaks on other ROCm versions. Use gen-pytorch-rocm-requirements.py everywhere (IE in documentation, CI) instead, which auto-detects the installed ROCm version and probes for a matching PyTorch wheel source.
This is a follow-up to the discussion in #1134