Merged
Conversation
Existing logic would override MMA vector_shape with the user-specified value from hardware constraints. This is incorrect unless the user-specified value matches the vector shape expected by the MMA instruction. Signed-off-by: Alex Zinenko <git@ozinenko.com>
ftynse
force-pushed
the
users/ftynse/vector-shape-no-override
branch
2 times, most recently
from
ae1c826 to
5c46785
Compare
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Alex Zinenko <git@ozinenko.com>
Tests verify that explicit vector_shapes in HardwareConstraint override default MMA matrix shapes. Includes tests for: - K dimension override (K=64 instead of default 32) - M/N dimension multiples (M=32, N=32 instead of default 16) - Non-multiple overrides (M=20, N=24 which are NOT multiples of 16) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ftynse
force-pushed
the
users/ftynse/vector-shape-no-override
branch
from
5c46785 to
6a6a81e
Compare
Signed-off-by: Alex Zinenko <git@ozinenko.com>
Signed-off-by: Alex Zinenko <git@ozinenko.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Existing logic would override MMA vector_shape with the user-specified value from hardware constraints. This is incorrect unless the user-specified value matches the vector shape expected by the MMA instruction.