Skip to content

Reland "Add F16 support to contraction input demotion pass (#23621)"#23850

Merged
hanhanW merged 2 commits intoiree-org:mainfrom
HanKuanChen:demote-contraction-inputs-to-f16
Mar 24, 2026
Merged

Reland "Add F16 support to contraction input demotion pass (#23621)"#23850
hanhanW merged 2 commits intoiree-org:mainfrom
HanKuanChen:demote-contraction-inputs-to-f16

Conversation

@HanKuanChen
Copy link
Copy Markdown
Contributor

@HanKuanChen HanKuanChen commented Mar 19, 2026 •
edited by hanhanW
Loading

This is a reland version of #23621 with the MSVC build fix by #23846.

ci-extra:windows_x64_msvc

@HanKuanChen
Copy link
Copy Markdown
Contributor Author

HanKuanChen commented Mar 19, 2026

cc: @hanhanW @efric

@hanhanW
Copy link
Copy Markdown
Contributor

hanhanW commented Mar 19, 2026

Let me trigger the job and I'll help land it if CI is green.

@HanKuanChen
Copy link
Copy Markdown
Contributor Author

HanKuanChen commented Mar 24, 2026

Ping. I think it is safe now. The CI failure is from iree/compiler/Codegen/LLVMGPU/test/ROCDL/config_tile_and_fuse_gfx950.mlir.

@Muzammiluddin-Syed-ECE
Copy link
Copy Markdown
Contributor

Muzammiluddin-Syed-ECE commented Mar 24, 2026

Ping. I think it is safe now. The CI failure is from iree/compiler/Codegen/LLVMGPU/test/ROCDL/config_tile_and_fuse_gfx950.mlir.

Do we know the cause of the failure in compiler/src/iree/compiler/Codegen/LLVMGPU/test/ROCDL:config_tile_and_fuse_gfx950.mlir?

@HanKuanChen
Copy link
Copy Markdown
Contributor Author

HanKuanChen commented Mar 24, 2026

Ping. I think it is safe now. The CI failure is from iree/compiler/Codegen/LLVMGPU/test/ROCDL/config_tile_and_fuse_gfx950.mlir.

Do we know the cause of the failure in compiler/src/iree/compiler/Codegen/LLVMGPU/test/ROCDL:config_tile_and_fuse_gfx950.mlir?

I don't know. But the failure is not related to this PR because the option in this PR is not enabled by default.

@Muzammiluddin-Syed-ECE
Copy link
Copy Markdown
Contributor

Muzammiluddin-Syed-ECE commented Mar 24, 2026

Ping. I think it is safe now. The CI failure is from iree/compiler/Codegen/LLVMGPU/test/ROCDL/config_tile_and_fuse_gfx950.mlir.

Do we know the cause of the failure in compiler/src/iree/compiler/Codegen/LLVMGPU/test/ROCDL:config_tile_and_fuse_gfx950.mlir?

I don't know. But the failure is not related to this PR because the option in this PR is not enabled by default.

Ok let me try it locally and check

@efric
Copy link
Copy Markdown
Member

efric commented Mar 24, 2026

You might be on a commit where this was broken. You can try rebasing your changes on top of main and running ci again

@HanKuanChen
Reland "Add F16 support to contraction input demotion pass (iree-org#…
959377b 
…23621)"

Signed-off-by: Han-Kuan Chen <hankuan.chen@sifive.com>
@HanKuanChen
reference: iree-org#23846
8797c21 
Signed-off-by: Han-Kuan Chen <hankuan.chen@sifive.com>
@HanKuanChen HanKuanChen force-pushed the demote-contraction-inputs-to-f16 branch from 082c924 to 8797c21 Compare March 24, 2026 16:09
@hanhanW
Copy link
Copy Markdown
Contributor

hanhanW commented Mar 24, 2026

https://github.com/iree-org/iree/actions/runs/23499667009/job/68392546539?pr=23850 is green, landing the PR

@hanhanW hanhanW merged commit 0a13120 into iree-org:main Mar 24, 2026
57 checks passed
@HanKuanChen HanKuanChen deleted the demote-contraction-inputs-to-f16 branch March 24, 2026 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hanhanW hanhanW hanhanW approved these changes

@MaheshRavishankar MaheshRavishankar Awaiting requested review from MaheshRavishankar MaheshRavishankar is a code owner

@IanWood1 IanWood1 Awaiting requested review from IanWood1 IanWood1 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@HanKuanChen @hanhanW @Muzammiluddin-Syed-ECE @efric