Skip to content

[Tuner][Codegen] Add convert constraints to smtlib string to python binding#23840

Merged
RattataKing merged 12 commits intoiree-org:mainfrom
RattataKing:add_hook
Mar 20, 2026
Merged

[Tuner][Codegen] Add convert constraints to smtlib string to python binding#23840
RattataKing merged 12 commits intoiree-org:mainfrom
RattataKing:add_hook

Conversation

@RattataKing
Copy link
Copy Markdown
Contributor

@RattataKing RattataKing commented Mar 18, 2026 •
edited
Loading

Add constraintsOp to SMTLIB string conversion to python bindings.

Issue: #23535

@RattataKing RattataKing mentioned this pull request Mar 18, 2026
Open
11 tasks
bangtianliu
bangtianliu requested changes Mar 18, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@bangtianliu bangtianliu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new C API function ireeCodegenConvertConstraintsToSMTModule is NOT added to the API export files.

  cd compiler/src/iree/compiler/API
  python3 generate_exports.py

kuhar
kuhar reviewed Mar 18, 2026
View reviewed changes
Comment thread compiler/bindings/python/test/api/tuner_api_test.py Outdated
kuhar
kuhar reviewed Mar 18, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@kuhar kuhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to expose this to python -- don't we only need the SMTLIB string?

@RattataKing RattataKing changed the title [Tuner][Codegen] Add convert constraints to smt to python binding [Tuner][Codegen] Add convert constraints to smtlib string to python binding Mar 18, 2026
kuhar
kuhar reviewed Mar 18, 2026
View reviewed changes
Comment thread compiler/bindings/python/IREECompilerDialectsModule.cpp Outdated
Comment thread compiler/bindings/python/IREECompilerDialectsModule.cpp Outdated
Comment thread compiler/src/iree/compiler/API/Internal/IREECodegenDialectCAPI.cpp Outdated
@kuhar
Copy link
Copy Markdown
Member

kuhar commented Mar 19, 2026

You have to rebase on top of main to make test failures go away

@RattataKing RattataKing enabled auto-merge (squash) March 19, 2026 20:40
@RattataKing RattataKing force-pushed the add_hook branch 2 times, most recently from 66701bc to a4bbe58 Compare March 20, 2026 16:22
@RattataKing RattataKing merged commit d1e00f1 into iree-org:main Mar 20, 2026
53 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kuhar kuhar kuhar approved these changes

@bangtianliu bangtianliu bangtianliu approved these changes

@hanhanW hanhanW Awaiting requested review from hanhanW hanhanW is a code owner

@Max191 Max191 Awaiting requested review from Max191 Max191 is a code owner

@MaheshRavishankar MaheshRavishankar Awaiting requested review from MaheshRavishankar MaheshRavishankar is a code owner

@qedawkins qedawkins Awaiting requested review from qedawkins qedawkins is a code owner

@benvanik benvanik Awaiting requested review from benvanik benvanik is a code owner

@IanWood1 IanWood1 Awaiting requested review from IanWood1 IanWood1 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RattataKing @kuhar @bangtianliu