[Codegen] Fix the reshape propagation in InsertBatchDimForBatchlessConv#23835
Merged
[Codegen] Fix the reshape propagation in InsertBatchDimForBatchlessConv#23835
Conversation
The phase 2 propagation should only allow `collapse_shape`. Otherwise, the `expand_shape` op can be bubbled up first. Then it becomes a blocker for sinking down `collapse_shape`. ``` collapse_shape linalg.generic expand_shape ``` Signed-off-by: hanhanW <hanhan0912@gmail.com>
hanhanW
requested review from
MaheshRavishankar,
Max191 and
qedawkins
as code owners
Abhishek-Varma
approved these changes
Mar 20, 2026
Contributor
Abhishek-Varma
left a comment
Abhishek-Varma
left a comment
There was a problem hiding this comment.
Thanks for this @hanhanW ! It worked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The phase 2 propagation should only allow
collapse_shape. Otherwise, theexpand_shapeop can be bubbled up first. Then it becomes a blocker for sinking downcollapse_shape.Fixes #23812