Draft
Conversation
Wire VDMFMA virtual intrinsics into the kernel configuration pipeline so they are automatically selected for skinny GEMMs (M<=8). Add e2e tests verifying correctness on ROCM hardware. Key changes: - IREEGPUAttrs.cpp: Extend getVirtualIntrinsics to return VDMFMA intrinsics from compatible 16x16 MFMA base intrinsics - ConfigUtils.cpp: Derive VDMFMA candidates in getMmaScheduleFromProblem with M-size guard to prevent selection for large M - GPUPackToIntrinsics.cpp: Add MmaInterfaceAttr fallback for VirtualMMA in getPackedSizes - config_tile_and_fuse.mlir: Add skinny GEMM config selection tests - skinny_gemm_vdmfma.mlir: E2E ROCM correctness tests Signed-off-by: Eric Feng <Eric.Feng@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ci-extra: test_torch