[Tokenizer] Fix silent output truncation in encode/decode finalize#23828
Merged
jtuyls merged 1 commit intoiree-org:mainfrom Apr 3, 2026
Merged
[Tokenizer] Fix silent output truncation in encode/decode finalize#23828jtuyls merged 1 commit intoiree-org:mainfrom
jtuyls merged 1 commit intoiree-org:mainfrom
Conversation
21df09d to
6a7f673
Compare
benvanik
requested changes
Mar 25, 2026
Return RESOURCE_EXHAUSTED instead of silently truncating when the output buffer is too small, matching the documented API contract in tokenizer.h. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Jorn <jorn.tuyls@gmail.com>
6a7f673 to
4337664
Compare
benvanik
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Return RESOURCE_EXHAUSTED instead of silently truncating when the output buffer is too small, matching the documented API contract in tokenizer.h.
Test results
HuggingFace smoketest (
huggingface_smoketest.py)1667/1667 tokenization comparisons pass across ~80 HuggingFace models (0 mismatches).
76 additional tests fail to load (not tokenization mismatches) — these are tiktoken models listed in the HF smoketest that aren't valid HuggingFace model identifiers. They're tested by the dedicated tiktoken smoketest instead. These tests are removed from the HF smoketest in #23830.
Tiktoken smoketest (
tiktoken_smoketest.py)72/76 tokenization comparisons pass across 4 tiktoken encodings (cl100k_base, o200k_base, r50k_base, p50k_base).
4 failures — identical between upstream and this PR (pre-existing, same as
fix-tokenizer-added-tokensbranch):special_token_endoftext<|endoftext|>as special token; tiktoken'sencode_ordinarytreats it as literal textspecial_token_endoftextspecial_token_endoftextspecial_token_endoftextRoot cause: the IREE tokenizer has no "encode ordinary" mode (equivalent to tiktoken's
disallowed_special=()). Fixed in #23830.