[wip] Implement WidenInnerTiledReduction#23822
Closed
efric wants to merge 2 commits intousers/efric/VDMFMA-1from
Closed
[wip] Implement WidenInnerTiledReduction#23822efric wants to merge 2 commits intousers/efric/VDMFMA-1from
efric wants to merge 2 commits intousers/efric/VDMFMA-1from
Conversation
Introduce a pass that widens VDMFMA accumulator operands from the collapsed (vector<2xT>) to the native hardware (vector<4xT>) form. This hoists the expand/collapse out of the reduction loop, reducing redundant interleave/deinterleave operations per iteration. Key changes: - IREEGPUAttrs.td: Add promotedAcc field to InnerTiledSemanticsAttr - IREEGPUAttrs.cpp: promotedAcc handling in getTileTypes; accIsNative parameter in buildVDMFMAOps/buildUnderlyingOperations - WidenInnerTiledReduction.cpp: New pass implementation - Transforms.cpp: Use getTileTypes from semantics (not kind directly) to respect promotedAcc; update all InnerTiledSemanticsAttr::get sites - Passes.td/Passes.cpp: Register and wire into pipeline - Tests: widen_inner_tiled_reduction.mlir, promotedAcc=true test in lower_inner_tiled.mlir Signed-off-by: Eric Feng <Eric.Feng@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.