draft/extended-isupport: Introduce value concatenation semantics#612
Open
ValwareIRC wants to merge 4 commits into
Open
draft/extended-isupport: Introduce value concatenation semantics#612ValwareIRC wants to merge 4 commits into
ValwareIRC wants to merge 4 commits into
Conversation
This goes towards solving problems that exist with ISUPPORT token values that have the potential to overflow the line limit. This came after a conversation on #ircv3 on Libera regarding `CLIENTTAGDENY`. While I will be recommending we take `CLIENTTAGDENY` another direction in another spec addendum, I still think this goes towards solving other problems that may come up in future, like with `draft/FILEHOST` which expects a URL which technically can be thousands of bytes long, and just makes 005 a bit unsuitable for that kind of stuff. I'd like to both try to solve this with concatenation logic as well as still suggest moving some things out of ISUPPORT altogether in a separate PR.
ValwareIRC
changed the title
Separators are none of our business
Contributor
|
This is a breaking change. It cannot be added to the existing spec without breaking clients. |
Contributor
Author
|
If anyone wants to test, I've implemented the 0.2 on ObbyIRCd (UnrealIRCd fork) at obbyworld/ObbyIRCd@d28ea32 with the PR for ObsidianIRC client here: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This goes towards solving problems that exist with ISUPPORT token values that have the potential to overflow the line limit. This came after a conversation on #ircv3 on Libera regarding
CLIENTTAGDENY. While I will be recommending we takeCLIENTTAGDENYanother direction in another spec addendum, I still think this goes towards solving other problems that may come up in future, like withdraft/FILEHOSTwhich expects a URL which technically can be thousands of bytes long, and just makes 005 a bit unsuitable for that kind of stuff.I'd like to both try to solve this with concatenation logic as well as still suggest moving some things out of ISUPPORT altogether in a separate PR, but it seemed this WIP was the right place for this enhancement.