Remove BackgroundSocket wrapper, use IOPubThread directly#1505
Open
erikgaas wants to merge 2 commits intoipython:mainfrom
Open
Remove BackgroundSocket wrapper, use IOPubThread directly#1505erikgaas wants to merge 2 commits intoipython:mainfrom
BackgroundSocket wrapper, use IOPubThread directly#1505erikgaas wants to merge 2 commits intoipython:mainfrom
Conversation
BackgroundSocket was a thin wrapper around IOPubThread that provided send/send_multipart and deprecated zmq socket attribute proxying (since ipykernel 4.3.0, 2016). Move send() to IOPubThread and remove the wrapper. - Add send() method to IOPubThread - Remove BackgroundSocket class from iostream.py - Update kernelapp.py to use iopub_thread directly - Update inprocess/ipkernel.py to use IOPubThread type - Simplify test to test IOPubThread.send directly
Author
|
tbh im not totally clear on how testing is working on this since many fail. could use some pointers on this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BackgroundSocketwas a thin wrapper aroundIOPubThreadthat providedsend/send_multipartmethods and deprecated zmq socket attribute proxying (deprecated since ipykernel 4.3.0 in 2016 — 10 years ago).Since
IOPubThreadalready hassend_multipart, the wrapper is unnecessary. This PR moves thesend()convenience method toIOPubThreadand removesBackgroundSocketentirely.Changes
send()method toIOPubThreadBackgroundSocketclass fromiostream.pybackground_socketattribute fromIOPubThreadkernelapp.pyto assigniopub_threaddirectly asiopub_socketinprocess/ipkernel.pyto useIOPubThreadtypeIOPubThread.senddirectly4 files changed, 11 insertions, 70 deletions.