chore: extend lint-staged glob to cover yml and yaml#57
Merged
Conversation
CI's prettier --check covers all YAML files, but the lint-staged pre-commit hook only globbed ts/tsx/js/mjs/json/md/css. That meant edits to .github/dependabot.yml could pass the commit hook locally and then fail CI on formatting (one example: PR #56's first push). Bringing the two checks into sync.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
yml,yamlto thelint-stagedglob inpackage.jsonso that prettier runs on YAML files at commit time, matching what CI'sprettier . --checkalready enforces.Why this matters: edits to
.github/dependabot.yml(and any other YAML in the repo) could pass the local pre-commit hook and then fail CI on formatting. PR #56 hit this exact gap on its first push. The two checks now stay in sync.