Remove protobufjs in favor of protons-runtime#60
Conversation
|
@talentlessguy you might gain more savings switching to protons and protons-runtime instead? It would dudupe with |
|
Note: I think in general I'd prefer to switch to |
thanks for the suggestion |
|
FWIW, last time I ran the benchmark suite, protons was just over 20% faster than protobuf-es when serializing/deserializing - https://github.com/ipfs/protons/tree/main/packages/protons-benchmark#usage These kind of performance characteristics are very important to high traffic deployments like Lodestar so it's unlikely to be switched away from elsewhere. |
do you mean protobufjs, and not protons? |
|
I wonder how hard it would be to replace protobuf-es with protons, will give it a shot rn |
|
I guess the only thing is that protons compiles protobuf definitions to TypeScript and this is still a js project. |
|
@achingbrain is the benchmark encode or decode? We're only encode in this repo. |
Co-authored-by: ash <alan138@gmail.com>
|
Had to remove certain dead code that apparently was detected before to make CI pass (otherwise the coverage is too low). Should I open a separate PR to eliminate all dead code? To make it easier to review the current PR |

This closes #31
Switches to protons-runtime
All tests pass now