Update simple_l3 P4 program actions to use PSA pre-defined actions #302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsureshkumarp
requested review from
Namrata-intel,
dandaly,
mestery,
n-sandeep and
nupuruttarwar
Modified simple_l3 P4 program to use the PSA pre-defined send_to_port and ingress_drop actions instead of updating the psa_ingress_output_metadata_t structure directly. Signed-off-by: Venkata Suresh Kumar P <venkata.suresh.kumar.p@intel.com>
vsureshkumarp
force-pushed
the
pv_psa_program_change_v1
branch
from
a307377 to
72e9895
Compare
jafingerhut
approved these changes
Dec 5, 2022
jafingerhut
left a comment
jafingerhut
left a comment
There was a problem hiding this comment.
The changes to simple_l3.p4 look good to me. I am not familiar enough with the syntax of the command line arguments of the pip3 command to review the changes to the other file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified simple_l3 P4 program to use the PSA pre-defined send_to_port and ingress_drop actions instead of updating the psa_ingress_output_metadata_t structure directly.
Signed-off-by: Venkata Suresh Kumar P venkata.suresh.kumar.p@intel.com