feat: consistent wait across all commands#506
Open
avirtopeanu-ionos wants to merge 35 commits intomasterfrom
Open
feat: consistent wait across all commands#506avirtopeanu-ionos wants to merge 35 commits intomasterfrom
avirtopeanu-ionos wants to merge 35 commits intomasterfrom
Conversation
6765d6b to
0e37ebd
Compare
…elp which cobra redirects to a blank command
183b043 to
6252289
Compare
04153fd to
a462f03
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Adds global
--wait / -wflag.Adds per-command
--timeoutflag and also-tshorthand if it is not already defined. (We cannot add a global --timeout flag while conditionally adding-tshorthand - there are some commands that already define this-tshorthand for something else.)Adds a
httpClientwhich we use to dynamically wait based on the retrieved hrefWe can find the href by pausing (catch the output in a buffer) after executing a command, and then working from there with what info we caught through the printer pkg. If we don't have the href yet, try running the equivalent
getcommand with whatever flags are common between the two commands.KNOWN ISSUES
The default timeout might be too low. It is consistently not enough for kubernetes resources, and the resources are still DEPLOYING when the waiting ends.
if using --wait:
hrefas a response key