fix(angular): transition plays when using browser buttons#28530
Merged
liamdebeasi merged 2 commits intofeature-8.0from Nov 16, 2023
Merged
fix(angular): transition plays when using browser buttons#28530liamdebeasi merged 2 commits intofeature-8.0from
liamdebeasi merged 2 commits intofeature-8.0from
Conversation
Co-authored-by: hoi4 <hoi4@users.noreply.github.com>
2 tasks
sean-perkins
approved these changes
Nov 15, 2023
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #16569
What is the current behavior?
Ionic Angular's routing integration disables page transitions when using the browser back/forward buttons.
What is the new behavior?
Does this introduce a breaking change?
We're not aware of any breaking changes here, though it's possible some developers were relying on this behavior. As a result, we are targeting Ionic 8 to minimize any potential negative impact this fix may have on developers.
Other information
Supersedes #28188
Dev build:
7.5.6-dev.11700068172.15ce9b35