fix: Improve editor button padding#9
Merged
OS-pedrogustavobilro merged 1 commit intofeat/RMET-4099/android-implementationfrom Mar 24, 2026
Merged
Conversation
OS-pedrogustavobilro
requested review from
OS-ruimoreiramendes and
alexgerardojacinto
alexgerardojacinto
approved these changes
Mar 23, 2026
OS-pedrogustavobilro
merged commit 46d3743
into
feat/RMET-4099/android-implementation
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I've been struggling to tap the ok button in the built-in image editor a lot, especially in portrait mode when they are very close to the navigation bar, and feel like this could be something that could cause complaints for Capacitor users. When I compare it with iOS, it's much easier to tap the button there. Also it's not the best for accessibility.
Basically this PR gives the buttons a bit more padding so that they can be clicked better.
I checked a few different Android device sizes, easier to tap the buttons portrait and landscape now, and looks better imo.
But feel free to test on your end and provide feedback if you agree with this change or not.
Screenshots