-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix throwing data URI requests #8304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
data: request throw because NSURLResponse is not a HTTPURLRepsonse
|
Thanks @frederikbosch! Do you have a reproduction for this issue, or can it be seen in basically any minimal project that uses CapacitorHttp? |
|
@theproducer I don't at the moment. I have upgraded my app from 7 to 8 and I got crashes because of the forced casts. It might very well be that because of some other upgrades that I only now started with That data URIs fail can be proven quite easily by this SwiftFiddle. Moreover, it is kind of documented behavior. The
And a |
|
@markemer Much better to unpack the response optional, I have updated the PR. |
Since Capacitor 8.0 data: requests throw because NSURLResponse is not a HTTPURLRepsonse