Skip to content

docs(push-notifications-firebase): Xcode is required#521

Merged
jcesarmobile merged 5 commits intoionic-team:mainfrom
rbalet:patch-2
Mar 19, 2026
Merged

docs(push-notifications-firebase): Xcode is required#521
jcesarmobile merged 5 commits intoionic-team:mainfrom
rbalet:patch-2

Conversation

@rbalet
Copy link
Contributor

@rbalet rbalet commented Feb 24, 2026

Description

I've added it manually, through vsCode, and it didn't worked.

So I figured adding a little warning may be helpful

@vercel
Copy link

vercel bot commented Feb 24, 2026

@rbalet is attempting to deploy a commit to the Ionic Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it says "open Xcode"

then "and move the .plist file into your Xcode project as instructed by Firebase, ensuring to add it to all targets."
Firebase instructions also use a similar wording.

then a screenshot of Xcode with the file.

I don't think more hints are needed, if you added it from VSCode you didn't move it to your "Xcode project" but to just your project, and you didn't add the file "to all targets" since that's not possible from VSCode.

In any case, we could change the "You'll then want to" to something like "You'll then have to", since it's not really an option to not do it.

## Description
emphasis that xCode have to be used
@rbalet
Copy link
Contributor Author

rbalet commented Mar 18, 2026

@jcesarmobile I give you right, and maybe that is just me (and the couple of other thread I saw on the internet).

I've updated the text in favor of the have to with an emphasis on it.

Maybe it would help people like me that read through.
You can always close it if you do not find the use of it.

Thx

@jcesarmobile jcesarmobile changed the title docs(push-notifications-firebase.md): xCode is required docs(push-notifications-firebase): Xcode is required Mar 19, 2026
@jcesarmobile jcesarmobile merged commit 7eaa5bc into ionic-team:main Mar 19, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants