Update blockList entries as array #219
Conversation
Removed multiple entries from the blockList and added specific entries.
Removed wirelessBlockList and updated blacklist structure to use an array of integers.
Changed channelErrors type from array to object.
|
Now while doing the review (your changes look fine now), I noticed that we have two times blacklist, everything else is named blocklist (it's not introduced by this PR, but it could easily be fixed). I guess this is not by intention, @roesekoSICKAG, @julian-st, what do you think? |
|
@wolfram-ladurner, @julian-st: I found more schemas which are not in use and removed them. Hope, it is fine with you. |
|
Now everything is named "blacklist", but I think "blocklist" would be the right term, as it is used in the IOLW specification. Sorry if I wasn't clear about that in my previous comment... |
|
Hi everyone, I talked to my colleagues about the code changes. Overall, they found the changes sensible. They only had the following comment regarding the upper and lower limits: The upper and lower limit values only make sense if they are permanently blocked. That is, if they are fixed in the blocklist as a kind of initial value. These two frequencies must always be blocked as a buffer between the corner frequencies and the usable frequencies to prevent crosstalk. As of now:
Therefore, from our perspective, the following would be more sensible:
Best regards |
Hi Philippe, good catch, you are fully right, the details are given in the Annex H.1 of the IOLFW spec:
|
Renamed 'blackList' to 'blockList' and updated range values.
Removed multiple entries from the blockList and added specific entries.