Fix v2.1 output integrity and H264 decode fallback#2
Merged
Conversation
ValidateOutputIntegrity now follows v2.1 parquet/video paths, merge runs the check before WriteInfo, and finalizeVideos falls back to encoder when remux has no tracks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ValidateOutputIntegrityfor v2.1 (episode_*.parquetand per-episode video paths).lerobot/writer.gointegrity checks bycodebase_versionso v2.1 no longer uses v3 globs.finalizeVideosto fall through to encoder when H264 remux has no tracks (decode fallback case).WriteInfo./bin/in.gitignore.Test plan
go test ./...go build ./cmd/lerobot-golerobot-go validateon v2.1+mp4 and v2.1+jpg exports