Skip to content

fix(analytics, android, ios): cast item INDEX param to integer #8964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brojor wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −0
Open

fix(analytics, android, ios): cast item INDEX param to integer #8964

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .../reactnative/java/io/invertase/firebase/analytics/ReactNativeFirebaseAnalyticsModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,10 @@ private Bundle toBundle(ReadableMap readableMap) {
double number = itemBundle.getDouble(FirebaseAnalytics.Param.QUANTITY);
itemBundle.putInt(FirebaseAnalytics.Param.QUANTITY, (int) number);
}
if (itemBundle.containsKey(FirebaseAnalytics.Param.INDEX)) {
double number = itemBundle.getDouble(FirebaseAnalytics.Param.INDEX);
itemBundle.putLong(FirebaseAnalytics.Param.INDEX, (long) number);
}
Comment on lines +214 to +217
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There's an inconsistency in how numeric parameters are handled. The existing code for QUANTITY uses putInt, while this change uses putLong for INDEX. According to the Firebase SDK documentation, both parameters are expected to be of type long. For correctness and consistency, QUANTITY should also be handled as a long.

Additionally, using a more descriptive variable name instead of number would improve readability.

Suggested change
if (itemBundle.containsKey(FirebaseAnalytics.Param.INDEX)) {
double number = itemBundle.getDouble(FirebaseAnalytics.Param.INDEX);
itemBundle.putLong(FirebaseAnalytics.Param.INDEX, (long) number);
}
if (itemBundle.containsKey(FirebaseAnalytics.Param.INDEX)) {
double index = itemBundle.getDouble(FirebaseAnalytics.Param.INDEX);
itemBundle.putLong(FirebaseAnalytics.Param.INDEX, (long) index);
}

Copy link
Copy Markdown
Author

@brojor brojor Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the QUANTITY inconsistency — I'd prefer to keep that out of this PR to stay focused on the INDEX fix. If QUANTITY should indeed be a long per the Firebase SDK, that's a pre-existing issue and deserves its own PR so it can be reviewed and reverted independently.

For the variable naming, I intentionally kept number to stay consistent with the existing QUANTITY block right above, which uses the same pattern. Renaming only the new lines would introduce inconsistency within the same method.

validBundles.add(itemBundle);
}
}
Expand Down
3 changes: 3 additions & 0 deletions packages/analytics/ios/RNFBAnalytics/RNFBAnalyticsModule.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,9 @@ - (NSDictionary *)cleanJavascriptParams:(NSDictionary *)params {
if (item[kFIRParameterQuantity]) {
item[kFIRParameterQuantity] = @([item[kFIRParameterQuantity] integerValue]);
}
if (item[kFIRParameterIndex]) {
item[kFIRParameterIndex] = @([item[kFIRParameterIndex] integerValue]);
}
[newItems addObject:[item copy]];
}];
newParams[kFIRParameterItems] = [newItems copy];
Expand Down
Loading