Skip to content
This repository was archived by the owner on Apr 7, 2026. It is now read-only.

feat(android): Support data param in notification#1141

Open
aureosouza wants to merge 3 commits intoinvertase:mainfrom
aureosouza:support-notification-data-param
Open

feat(android): Support data param in notification#1141
aureosouza wants to merge 3 commits intoinvertase:mainfrom
aureosouza:support-notification-data-param

Conversation

@aureosouza
Copy link
Copy Markdown

Fixes: #1081

This fix avoids the need of sending a second data-only notification, in a similar behavior as iOS. More info on firebase data payload here.

Based on discussions from #393 (comment) and using similar solution as here we are injecting the data param on the method getDisplayedNotifications.

Obs.: firebase needs to inject the data param as well, for this we added a handleIntent override for the class that extends FirebaseMessagingService, further PRs will be necessary on firebase side. In case of react-native-firebase there is more info here.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Nov 8, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 6, 2024

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

@github-actions github-actions bot added the Stale label Dec 6, 2024
@mikehardy mikehardy added Keep Open this label avoids the stale bot and removed Stale labels Dec 6, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 6, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.08%. Comparing base (ae2953b) to head (4f4d300).
⚠️ Report is 54 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1141   +/-   ##
=======================================
  Coverage   77.08%   77.08%           
=======================================
  Files          32       32           
  Lines        1727     1727           
  Branches      556      556           
=======================================
  Hits         1331     1331           
  Misses        395      395           
  Partials        1        1           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Keep Open this label avoids the stale bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Notifee does not support extra params from Android intent back to JS

3 participants