Skip to content

Lock notes on orders if they are completed#11880

Open
matmair wants to merge 2 commits intoinventree:masterfrom
matmair:matmair/issue11879
Open

Lock notes on orders if they are completed#11880
matmair wants to merge 2 commits intoinventree:masterfrom
matmair:matmair/issue11879

Conversation

@matmair
Copy link
Copy Markdown
Member

@matmair matmair commented May 5, 2026

Fixes #11879

@matmair matmair added this to the 1.3.3 milestone May 5, 2026
@matmair matmair self-assigned this May 5, 2026
@matmair matmair requested a review from SchrodingersGat as a code owner May 5, 2026 23:23
@matmair matmair added bug Identifies a bug which needs to be addressed User Interface Related to the frontend / User Interface labels May 5, 2026
@netlify
Copy link
Copy Markdown

netlify Bot commented May 5, 2026

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit 237a7b1
🔍 Latest deploy log https://app.netlify.com/projects/inventree-web-pui-preview/deploys/69fa819543662b000891c420
😎 Deploy Preview https://deploy-preview-11880--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 93 (🔴 down 3 from production)
Accessibility: 81 (no change from production)
Best Practices: 100 (🟢 up 8 from production)
SEO: 78 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@matmair matmair added backport Apply this label to a PR to enable auto-backport action backport-to-1.3.x labels May 5, 2026
Comment thread src/frontend/src/pages/purchasing/PurchaseOrderDetail.tsx Outdated
Comment thread src/frontend/src/pages/sales/SalesOrderDetail.tsx Outdated
has_note: !!build.notes
has_note: !!build.notes,
// TODO @matmair - change API to include a "locked" attribute that we can check here
editable: build.status == 40 ? false : undefined
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a new global setting to check for ability to edit completed build orders?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Apply this label to a PR to enable auto-backport action backport-to-1.3.x bug Identifies a bug which needs to be addressed User Interface Related to the frontend / User Interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Editing/saving a note on a completed PO fails with no user feedback

2 participants