-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
refactor(backend): reduce API surface by unifying metadata endpoints #11035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(backend): reduce API surface by unifying metadata endpoints #11035
Conversation
…t of permanent redirects
✅ Deploy Preview for inventree-web-pui-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #11035 +/- ##
==========================================
- Coverage 88.18% 88.16% -0.02%
==========================================
Files 1290 1290
Lines 58142 58145 +3
Branches 1969 1969
==========================================
- Hits 51272 51264 -8
- Misses 6379 6390 +11
Partials 491 491
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
…reduce-metadata-endpoints
…reduce-metadata-endpoints
…r/InvenTree into reduce-metadata-endpoints
…reduce-metadata-endpoints
…reduce-metadata-endpoints
…reduce-metadata-endpoints
|
@SchrodingersGat this is ready for review, the needed change for the API client is already proposed inventree/inventree-python#285 You can see the passing test with that branch in https://github.com/inventree/InvenTree/actions/runs/20733404036/job/59525935718 |
|
@matmair this does look a lot cleaner. To confirm what you are doing here - all metadata is accessed via |
|
@SchrodingersGat it sends a permanent redirect. If the client follows the redirect it still works. Most clients do that for GET but not for POST/PATCH, it is often configurable. That is largely why I marked the PR as breaking. |
|
Metadata is accessed via |
|
Happy with this to merge? |
|
Yes |

Replaces individual metadata endpoints with a generic endpoint and a bunch of permanent redirects. Obviously a breaking change.
This:
Requires a change to the client libary - inventree/inventree-python#285