Update broken settings.gradle.kts link in gradle-plugin and maven-plugin docs#41
Open
EoinTrial wants to merge 1 commit into
Open
Update broken settings.gradle.kts link in gradle-plugin and maven-plugin docs#41EoinTrial wants to merge 1 commit into
settings.gradle.kts link in gradle-plugin and maven-plugin docs#41EoinTrial wants to merge 1 commit into
Conversation
EoinTrial
changed the title
settings.gradle.kts link in gradle-plugin and maven-plugin docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Updated the broken relative link
./settings.gradle.kts#19in bothgradle-plugin/README.mdandmaven-plugin/README.mdto point to the correct GitHub URL with a proper line anchor.Why
The link was a relative path that resolved to a non-existent file within each module's directory. The actual
settings.gradle.ktsfile containing the KSP version definition lives at the repo root. The#19anchor also needed updating to#L19for GitHub's line-anchor syntax to work.Fixes #34
Todo:
Release Notes
Fixed broken docs link in the Gradle plugin and Maven plugin READMEs that pointed to a non-existent
settings.gradle.ktsfile. The link now correctly points to line 19 of the rootsettings.gradle.kts, where the KSP version is defined.