[rid] Extract polygon conversion from geo module#1552
Open
RustedBones wants to merge 2 commits into
Open
Conversation
RustedBones
force-pushed
the
geo-s2-split
branch
from
2324c5e to
3a7c602
Compare
RustedBones
force-pushed
the
geo-s2-split
branch
2 times, most recently
from
a956fd9 to
77f7174
Compare
BenjaminPelletier
approved these changes
Jul 6, 2026
BenjaminPelletier
left a comment
BenjaminPelletier
left a comment
Member
There was a problem hiding this comment.
LGTM after enhancing a few error messages (see comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AreaToCellIDsdefined ingeomodule is specific to theridfor theareaparameter conversion.Define a
FromGeoPolygonStringinridcommon api to convert the area to an internal polygon representation.