[helm] Add support for external monitoring option #1330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-glu
force-pushed
the
helm_monitoring_external
branch
from
b81d2ab to
ddea450
Compare
barroco
reviewed
Jan 2, 2026
| "type": "string" | ||
| }, | ||
| "allowedIPs": { | ||
| "description": "List of IP allowed to connect to the service, for AWS only", |
Contributor
There was a problem hiding this comment.
Suggested change
| "description": "List of IP allowed to connect to the service, for AWS only", | |
| "description": "List of IP ranges allowed to connect to the service, for AWS only", |
| kind: Ingress | ||
| metadata: | ||
| annotations: | ||
| {{- include (printf "%s-ingress-dss-gateway-annotations" $cloudProvider) |
Contributor
There was a problem hiding this comment.
Suggested change
| {{- include (printf "%s-ingress-dss-gateway-annotations" $cloudProvider) | |
| {{- include (printf "%s-ingress-prometheus-annotations" $cloudProvider) |
| selector: | ||
| app.kubernetes.io/instance: "{{$.Release.Name}}" | ||
| app.kubernetes.io/name: "prometheus" | ||
| type: NodePort |
Contributor
There was a problem hiding this comment.
Why using a Nodeport here instead of a LoadBalancer ?
| apiVersion: cloud.google.com/v1 | ||
| kind: BackendConfig | ||
| metadata: | ||
| name: promtheus-external |
Contributor
There was a problem hiding this comment.
Suggested change
| name: promtheus-external | |
| name: prometheus-external |
| app: {{$.Release.Name}}-prometheus | ||
| name: {{$.Release.Name}}-prometheus-external | ||
| annotations: | ||
| cloud.google.com/backend-config: '{"default": "promtheus-external"}' |
Contributor
There was a problem hiding this comment.
Suggested change
| cloud.google.com/backend-config: '{"default": "promtheus-external"}' | |
| cloud.google.com/backend-config: '{"default": "prometheus-external"}' |
|
|
||
| monitoring: | ||
| enabled: false | ||
| externalService: |
Contributor
There was a problem hiding this comment.
I don't think we want any example values in this file since it is default values taken into account by the chart.
Please move them to values.example.yaml.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the external monitoring option on helm chart as well.
Implementation is better than the tanka one, as it's support https, a following up PR will bring it up to date.