[_]: feat/add appearance section in General tab (Preferences)#27
Merged
[_]: feat/add appearance section in General tab (Preferences)#27
Conversation
larryrider
reviewed
Mar 25, 2026
| const toggleTheme = (theme: Theme) => setCurrentTheme(theme); | ||
|
|
||
| const persistDarkTheme = (value: boolean) => { | ||
| LocalStorageService.instance.set('theme:isDark', value ? 'true' : 'false'); |
There was a problem hiding this comment.
isnt value ? 'true' : 'false' the same as just value?
Contributor
Author
There was a problem hiding this comment.
local storage only allows strings as value, not boolean
larryrider
reviewed
Mar 25, 2026
src/context/theme/ThemeProvider.tsx
Outdated
|
|
||
| useEffect(() => { | ||
| const root = rootRef.current; | ||
| if (!root || currentTheme === undefined) return; |
There was a problem hiding this comment.
isnt it better to if (!root || !currentTheme) return;
larryrider
approved these changes
Mar 25, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new section in General tab (Preferences) to allow the user to switch the theme for the app (light, dark or system default config).