[_]: feat/add dropdown to select inxt domain#25
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughAdded Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Warning
CodeRabbit couldn't request changes on this pull request because it doesn't have sufficient GitHub permissions.
Please grant CodeRabbit Pull requests: Read and write permission and re-run the review.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/features/identity-setup/components/SelectMailInput.tsx`:
- Around line 35-44: The text input in SelectMailInput lacks a programmatic
label; update the input inside the SelectMailInput component to include an
accessible name (either add a visible <label> and connect it via htmlFor/id or
add an appropriate aria-label/aria-labelledby) so assistive tech can identify
the username field; ensure the chosen label text clearly describes the purpose
(e.g., "email username" or "username") and use the existing props/state (value,
onChangeValue, setIsFocused) without changing their behavior.
In `@src/features/identity-setup/components/UpdateEmail.tsx`:
- Around line 22-25: The click handler currently forwards fullEmail without
validating username; update handleOnClick in UpdateEmail.tsx to trim and
validate username (e.g., const sanitized = username.trim(); ensure sanitized is
non-empty and matches your allowed pattern such as alphanumeric plus allowed
symbols) and only call onNext(`${sanitized}${domain}`) when valid; when invalid,
prevent advancing and surface feedback (set a local error state like
usernameError or disable the Next button) so empty/whitespace/illegal usernames
are blocked before calling onNext.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: ff25c23d-73d4-4587-818a-322b97057559
📒 Files selected for processing (7)
src/constants.tssrc/features/identity-setup/components/SelectMailInput.tsxsrc/features/identity-setup/components/UpdateEmail.tsxsrc/features/mail/components/tray/header/index.tsxsrc/features/mail/components/tray/index.tsxsrc/features/mail/components/tray/search-input/index.tsxsrc/features/mail/components/tray/tray-empty-state/index.tsx
larryrider
reviewed
Mar 25, 2026
| const { translate, translateArray } = useTranslationContext(); | ||
| const [email, setEmail] = useState<string>(''); | ||
| const [username, setUsername] = useState<string>(''); | ||
| const [domain, setDomain] = useState<Domain>('@intx.me'); |
larryrider
reviewed
Mar 25, 2026
src/constants.ts
Outdated
|
|
||
| export const HUNDRED_TB = 100 * 1024 * 1024 * 1024 * 1024; | ||
|
|
||
| export const INTERNXT_EMAIL_DOMAINS = ['@intx.me', '@inxt.eu', '@encrypt.eu'] as const; |
|
larryrider
approved these changes
Mar 25, 2026
xabg2
deleted the
feature/dropdown-to-select-inxt-domain-when-setting-up-new-mail
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a dropdown to select the init domain when setting up the identity.