Conversation
…fixed typescript errors
Deploying drive-web with
|
| Latest commit: |
b08c6c7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f9e8666e.drive-web.pages.dev |
| Branch Preview URL: | https://feature-typescript-check.drive-web.pages.dev |
src/app/drive/components/FileViewer/viewers/FileImageViewer/FileImageViewer.tsx
Outdated
Show resolved
Hide resolved
| if (item) { | ||
| setCurrentVersion({ | ||
| id: item.fileId, | ||
| id: item.uuid, |
There was a problem hiding this comment.
Yes, that's fine, it's only used as a key. Here, the fileId is not used for downloading, as it may be null if an empty file has been uploaded, I have modified it so that it always uses a unique string value
There was a problem hiding this comment.
then lets change it also to uuid so its consistent here:
sg-gs
left a comment
sg-gs
left a comment
There was a problem hiding this comment.
For all the reviewers here, be aware that although this PR is for enforcing types, there are logic changes that although could appear small or non-relevant, are still logic changes so they can trigger unintended effects, requiring a regression test.
| test('When the file has no fileId, then it should indicate it is empty', () => { | ||
| const emptyFile = { size: 0, fileId: null } as DriveFileData; | ||
|
|
||
| expect(isFileEmpty(emptyFile)).toBe(true); |
There was a problem hiding this comment.
nit: consider using toBeTruthy()
…ecessary token from typecheck action
…ewer and refactor imports in Backups components
|
5 participants
Description
Related Issues
Related Pull Requests
Checklist
Testing Process
File Download
PDF Viewer
Image Viewer
Version History
PGP Key Generation / Sign Up
ed25519Legacy)Credential Update (not tested in local because CORS error)
keys.private.{ ecc, kyber }payload is sent correctly to the backendAdditional Notes