Improve validation error messages to show specific invalid characters #1480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhanced SafeValueValidator to display the actual invalid characters in error messages, making it easier for users to identify and fix validation issues. Changes: - Updated SafeValueValidator to extract and display invalid characters - Added new translation key (value_is_not_safe_with_chars) for EN and ET - Added tests to verify invalid characters are shown in error messages - Validation logic remains unchanged - only error messages improved Affected models: User (given_names, surname) and BillingProfile (name, street, city, postal_code, vat_code) Before: Generic message about allowed characters After: Shows specific invalid characters like 'Contains invalid character(s): ,' This addresses user feedback where validation errors were unclear, requiring trial-and-error to find problematic characters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhanced SafeValueValidator to display the actual invalid characters in error messages, making it easier for users to identify and fix validation issues.
Changes:
Affected models: User (given_names, surname) and BillingProfile (name, street, city, postal_code, vat_code)
Before: Generic message about allowed characters
After: Shows specific invalid characters like 'Contains invalid character(s): ,'
This addresses user feedback where validation errors were unclear, requiring trial-and-error to find problematic characters.