Skip to content

phase 3b T6: voice-note card + VoiceNotePlayer single-instance coordinator #640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
intendednull merged 4 commits into from
May 9, 2026
Merged

phase 3b T6: voice-note card + VoiceNotePlayer single-instance coordinator #640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
34d18c4
feat(phase-3b T6): voice-note card + single-instance VoiceNotePlayer
intendednull May 9, 2026
7c864eb
test+docs(phase-3b T6): voice-note browser tests + close out plan
intendednull May 9, 2026
7bcd845
fix(phase-3b T6): close AudioContext + gate pause-effect re-fire
intendednull May 9, 2026
adfd584
style(phase-3b T6): fmt the voice-note browser test
intendednull May 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions crates/web/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ web-sys = { version = "0.3", features = [
"ScrollIntoViewOptions", "ScrollBehavior", "ScrollLogicalPosition",
"DisplayMediaStreamConstraints",
"AudioContext", "BaseAudioContext", "AudioNode",
"AudioBuffer",
"AnalyserNode", "MediaStreamAudioSourceNode",
"RtcSignalingState", "RtcRtpTransceiver",
"Response", "Headers",
Expand Down
5 changes: 5 additions & 0 deletions crates/web/src/app.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,11 @@ pub fn App() -> impl IntoView {
// the same `UploadQueue`.
provide_context(crate::upload_state::UploadQueue::new());

// Phase 3b T6 — single-instance voice-note player. Each
// `<AttachmentVoiceNote>` reads this from context to coordinate
// "starting one pauses any other" per spec §Voice note.
provide_context(crate::voice_note_player::VoiceNotePlayer::new());

// Phase 3c.3 — per-channel reaction recency. Drives the picker's
// "recent" shelf in both the composer's emoji button and the
// row's "more reactions" toolbar. The Resource refreshes when
Expand Down
Loading