Remove stale ConvTranspose3d complex half parity xfail#3285
Open
Remove stale ConvTranspose3d complex half parity xfail#3285
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the XPU test harness to stop inheriting a CUDA expectedFailure decoration for the nn.ConvTranspose3d CPU/GPU parity test, so that XPU no longer treats the test as an expected failure when it now passes.
Changes:
- Add
("nn.ConvTranspose3d", "test_cpu_gpu_parity")to the_cuda_xfail_xpu_passallowlist so XPU doesn’t inherit CUDA’sexpectedFailurefor that test.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Performance outliers, please check!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes:
#3030
This PR removes the stale inherited expected failure for ConvTranspose3d complex half CPU/GPU parity on XPU. The test now passes with the corresponding PyTorch change: pytorch/pytorch#179713