fix(cmake): Correct macOS KEXT build using absolute SDK paths #992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The KEXT (PcmMsrDriver) build failed on macOS because it could not find kernel headers like `<IOKit/IOLib.h>`. This was caused by CMake incorrectly resolving include paths to `/System/Library/...` instead of the correct path inside the macOS SDK. This commit fixes the issue by localizing the solution to the KEXT's `CMakeLists.txt`. It now dynamically detects the active macOS SDK path using `xcrun` and uses it to construct absolute include paths for the KEXT target only. This ensures the KEXT can find its required kernel headers without affecting other user-space targets that may depend on libraries from standard locations like Homebrew. Close: #928
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a build failure in the macOS Kernel Extension (KEXT) by correcting how CMake locates kernel headers. The previous code used CMAKE_OSX_SYSROOT which could incorrectly resolve to /System/Library/... instead of the SDK path. The fix dynamically detects the active macOS SDK using xcrun --show-sdk-path and constructs absolute include paths specific to the KEXT target.
- Adds SDK path detection using
xcrun --sdk macosx --show-sdk-path - Updates include directories to use the detected SDK path instead of
CMAKE_OSX_SYSROOT - Localizes the fix to the KEXT's CMakeLists.txt without affecting other targets
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The KEXT (PcmMsrDriver) build failed on macOS because it could not find kernel headers like
<IOKit/IOLib.h>. This was caused by CMake incorrectly resolving include paths to/System/Library/...instead of the correct path inside the macOS SDK.This commit fixes the issue by localizing the solution to the KEXT's
CMakeLists.txt. It now dynamically detects the active macOS SDK path usingxcrunand uses it to construct absolute include paths for the KEXT target only.This ensures the KEXT can find its required kernel headers without affecting other user-space targets that may depend on libraries from standard locations like Homebrew.
Close: #928